X Rebirth - UI Modding
  1. X Rebirth - UI Modding
  2. XRUIMOD-255

FFI/Lua: Inconsistent behavior if objects are wrecked/under construction/etc.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Important Important
    • Resolution: Fixed
    • Affects Version/s: 3.50 - Beta 1
    • Fix Version/s: 4.31 Beta 1
    • Labels:

      Description

      The following Lua/FFI functions show a different behavior based on the object's current state.

      For example if calling IsDestructible() or IsShip() on a ship which is under construction these functions would return false. This behavior was never actually intended since the operational state can be checked by other means (f.e. FFI/Lua: IsComponentOperational() / Lua: IsComponentConstruction()).

      Hence, we'd change the behavior of the following functions to only determine the object based on the object's class (rather than a combination of its class and operational state):

      Lua:

      • GetPlayerDroneSystems()

      FFI:

      • GetComponentDetails()
      • GetEntityActiveIcon()
      • GetEntityInactiveIcon()
      • GetEntitySelectedIcon()
      • HasSmalltalkOption()
      • IsAsteroid()
      • IsBomb()
      • IsCrate()
      • IsDestructible()
      • IsEntity()
      • IsShip()
      • IsStation()
      • IsSwitchable()

      Sidenote: This also resolves incorrect errors one would get when calling one of these functions with an object of the correct class while the object would not be in an operational state.

        Issue Links

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              Stefan Hett
              Reporter:
              Stefan Hett
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: