X Rebirth - UI Modding
  1. X Rebirth - UI Modding
  2. XRUIMOD-272

Lua: drop unused parameters from GetMissionDetails()/GetMissionObjective()/GetMissionOfferDetails()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Important Important
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.31 Beta 1
    • Labels:
      None

      Description

      GetMissionDetails()/GetMissionObjective()/GetMissionOfferDetails() take the following parameters:
      fontname, fontsize, textwidth

      However, these parameters were never evaluated (beyond performing the usual type-checks for these).

      Hence, we'd drop the type-checks and document the (dropped) parameters.
      To not break backwards compatibility, we'd still accept calls with the additional parameters (which are then completely ignored).

        Activity

        Stefan Hett created issue -
        Stefan Hett made changes -
        Field Original Value New Value
        Link This issue refers to XRDEV-2281 [ XRDEV-2281 ]
        Stefan Hett made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Stefan Hett made changes -
        Summary Lua: drop unused parameters from GetMissionDetails() Lua: drop unused parameters from GetMissionDetails()/GetMissionObjective()/GetMissionOfferDetails()
        Stefan Hett made changes -
        Description GetMissionDetails() takes the following parameters:
        fontname, fontsize, textwidth

        However, these parameters were never evaluated (beyond performing the usual type-checks for these).

        Hence, we'd drop the type-checks and document the (dropped) parameters.
        To not break backwards compatibility, we'd still accept calls to GetMissionDetails() with the additional parameters.
        GetMissionDetails()/GetMissionObjective()/GetMissionOfferDetails() take the following parameters:
        fontname, fontsize, textwidth

        However, these parameters were never evaluated (beyond performing the usual type-checks for these).

        Hence, we'd drop the type-checks and document the (dropped) parameters.
        To not break backwards compatibility, we'd still accept calls to GetMissionDetails() with the additional parameters.
        Stefan Hett made changes -
        Description GetMissionDetails()/GetMissionObjective()/GetMissionOfferDetails() take the following parameters:
        fontname, fontsize, textwidth

        However, these parameters were never evaluated (beyond performing the usual type-checks for these).

        Hence, we'd drop the type-checks and document the (dropped) parameters.
        To not break backwards compatibility, we'd still accept calls to GetMissionDetails() with the additional parameters.
        GetMissionDetails()/GetMissionObjective()/GetMissionOfferDetails() take the following parameters:
        fontname, fontsize, textwidth

        However, these parameters were never evaluated (beyond performing the usual type-checks for these).

        Hence, we'd drop the type-checks and document the (dropped) parameters.
        To not break backwards compatibility, we'd still accept calls with the additional parameters (which are then completely ignored).

          People

          • Assignee:
            Stefan Hett
            Reporter:
            Stefan Hett
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: